Skatepark: Add space below the Featured Image on the single post page #5061
Conversation
The logic behind the calc() code is trying to mimic the way the space gets calculated when a Featured Image isn't set
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| <!-- wp:group {"align":"full"} --> | |||
| <div class="wp-block-group alignfull"> | |||
| <!-- wp:post-featured-image {"align":"full"} /--></div> | |||
| <!-- wp:post-featured-image {"align":"full", "style":{"spacing":{"margin":{"bottom":"calc(2*var(--wp--style--block-gap) + 3*var(--wp--custom--gap--horizontal))"}}}} /--></div> | |||
There was a problem hiding this comment.
I don't think we should be using var() or calc() in block markup; It doesn't work in the FSE when you load that block template. It makes the block markup more verbose, but I'm of the opinion that we should be verbose there, even if it means more manual changes when things like "block gap" needs to change.
There was a problem hiding this comment.
About this, looks like there's a proposal so that those values are not empty on the block sidebar
There was a problem hiding this comment.
@MaggieCabrera Perhaps this PR could be moved to Approved but not mergable?
There was a problem hiding this comment.
no, I think we can merge this anyway, since only the UI is affected by the future change and not the actual looks of the site
scruffian
deleted the
fix/4976-skatepark-add-spacing-below-featured-image
branch
The logic behind the
calc()code is trying to mimic the way the space gets calculated when a Featured Image isn't set.Before:
After:
Closes #4976